Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[ESIMD] Rewrite Stencils tests using buffers #231

Closed
wants to merge 2 commits into from

Conversation

DenisBakhvalov
Copy link

@DenisBakhvalov DenisBakhvalov commented Apr 13, 2021

I analyzed the history of ESIMD stencil tests in CI and found that stencil tests are sensitive to the time limit. I.e. they are not hanging but timing out before finishing the job. Since #148 Stencil.cpp was failing several times per day.

As a first step to resolve the issue, we rewrite the stencil tests using SYCL buffers, which should improve performance.

Author: kychendev [email protected]

bader
bader previously approved these changes Apr 13, 2021
@DenisBakhvalov DenisBakhvalov changed the title [ESIMD] Temporary disabled stencil tests [ESIMD] Rewrite Stencils tests using buffers Apr 20, 2021
@DenisBakhvalov
Copy link
Author

Cuda failures are unrelated.

@kbobrovs
Copy link

@DenisBakhvalov, did you consider reverting #define DIM_SIZE (1 << 13) back to #define DIM_SIZE (1 << 10) as it was before #148?
Also, I think it is good to have both - USM and buffer-based tests, so you can add your new version as one more test.

@DenisBakhvalov
Copy link
Author

@DenisBakhvalov, did you consider reverting #define DIM_SIZE (1 << 13) back to #define DIM_SIZE (1 << 10) as it was before #148?
Also, I think it is good to have both - USM and buffer-based tests, so you can add your new version as one more test.

I tend to think we should decrease DIM_SIZE in order to fit into the time limits, but according to @kychendev, it will decrease the test coverage.

@DenisBakhvalov
Copy link
Author

Closed in favor of #244

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants