[Driver] Make the findVCToolChainViaEnvironment case-insensitive #3543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PATH usage on Windows is case-insensitive. There could be situations when toolchain path can't be obtained from PATH because of case-sensitivity of the findVCToolChainViaEnvironment. Reviewed By: rnk Differential Revision: https://reviews.llvm.org/D100361
|
Cherry-pick of https://reviews.llvm.org/D100361 in order to resolve massive llvm-test-suite failures with certain environment configurations. |
mdtoguchi
approved these changes
Apr 14, 2021
|
The failed tests are unrelated, they are going to be temporarily disabled here intel/llvm-test-suite#231 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PATH usage on Windows is case-insensitive. There could be situations
when toolchain path can't be obtained from PATH because of
case-sensitivity of the findVCToolChainViaEnvironment.
Reviewed By: rnk
Differential Revision: https://reviews.llvm.org/D100361