[SYCL][E2E] Fix L0 barrier test to handle counting events #15053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nrspruit
commented
Aug 13, 2024
nrspruit
commented
- Test2 in level_zero_barrier_optimization.cpp will only see Event Create or Host Reset if counting events are not used from the cache, which is default for immediate command list and in order list use.
- counting events cannot be reset so neither of these prints would be seen so this is optional.
- Test2 in level_zero_barrier_optimization.cpp will only see Event Create or Host Reset if counting events are not used from the cache, which is default for immediate command list and in order list use. - counting events cannot be reset so neither of these prints would be seen so this is optional. Signed-off-by: Neil R. Spruit <[email protected]>
|
@intel/llvm-gatekeepers please review and merge this change to address false negative with this test. |
Review from @intel/unified-runtime-reviewers is needed. |
igchor
approved these changes
Aug 14, 2024
|
@intel/llvm-gatekeepers please merge when able to fix this test case in CI. |
|
@intel/unified-runtime-reviewers review is still needed. |
aarongreig
approved these changes
Aug 15, 2024
AlexeySachkov
pushed a commit
to AlexeySachkov/llvm
that referenced
this pull request
Nov 26, 2024
- Test2 in level_zero_barrier_optimization.cpp will only see Event Create or Host Reset if counting events are not used from the cache, which is default for immediate command list and in order list use. - counting events cannot be reset so neither of these prints would be seen so this is optional. Signed-off-by: Neil R. Spruit <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.