[SYCL] Force Clang to emit complete object constructor for SYCLMemObjT #1652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCC produces two symbols for one of SYCLMemObjT's constructors: ``` _ZN2cl4sycl6detail11SYCLMemObjTC1EP7_cl_memRKNS0_7contextEmNS0_5eventESt10unique_ptrINS1_19SYCLMemObjAllocatorESt14default_deleteISA_E _ZN2cl4sycl6detail11SYCLMemObjTC2EP7_cl_memRKNS0_7contextEmNS0_5eventESt10unique_ptrINS1_19SYCLMemObjAllocatorESt14default_deleteISA_E ``` Those are complete object constructor and base object constructor. The difference is that complete object constructor initializes vtable, while base object constructor accepts it from a derived class. On the other hand, Clang is smart enough to see that SYCLMemObjT is a pure virtual class, and its complete object constructor can be dropped. This patch adds dumb implementation for missing member functions to SYCLMemObjT to force Clang behave the same way GCC does.
romanovvlad
requested changes
May 8, 2020
Signed-off-by: Ivan Karachun <[email protected]>
romanovvlad
approved these changes
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCC produces two symbols for one of SYCLMemObjT's constructors:
Those are complete object constructor and base object constructor. The
difference is that complete object constructor initializes vtable, while
base object constructor accepts it from a derived class.
On the other hand, Clang is smart enough to see that SYCLMemObjT is a
pure virtual class, and its complete object constructor can be dropped.
This patch adds dumb implementation for missing member functions to SYCLMemObjT
to force Clang behave the same way GCC does.