Skip to content

[SYCL] Force Clang to emit complete object constructor for SYCLMemObjT #1652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2020
Merged

[SYCL] Force Clang to emit complete object constructor for SYCLMemObjT #1652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21d1f2b
[SYCL] Force Clang to emit complete object constructor for SYCLMemObjT
May 7, 2020
7e5a7da
Address reviewers' comments
May 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sycl/include/CL/sycl/detail/sycl_mem_obj_i.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class SYCLMemObjI {
public:
virtual ~SYCLMemObjI() = default;

enum MemObjType { BUFFER, IMAGE };
enum MemObjType { BUFFER, IMAGE, UNDEFINED };

virtual MemObjType getType() const = 0;

Expand Down
7 changes: 7 additions & 0 deletions sycl/include/CL/sycl/detail/sycl_mem_obj_t.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,13 @@ class __SYCL_EXPORT SYCLMemObjT : public SYCLMemObjI {
static size_t getBufSizeForContext(const ContextImplPtr &Context,
cl_mem MemObject);

void *allocateMem(ContextImplPtr Context, bool InitFromUserData,
void *HostPtr, RT::PiEvent &InteropEvent) override {
throw runtime_error("Not implemented", PI_INVALID_OPERATION);
}

MemObjType getType() const override { return UNDEFINED; }

protected:
// Allocator used for allocation memory on host.
unique_ptr_class<SYCLMemObjAllocator> MAllocator;
Expand Down