[SYCL][CUDA][HIP] Propagate -foffload-fp32-prec-sqrt #17044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It follows the approach from intel#5141 and intel#5309 adding intermediate fcuda-prec-div flag. Signed-off-by: Sidorov, Dmitry <[email protected]>
MrSidims
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
MrSidims
commented
Feb 18, 2025
| !0 = !{i32 4, !"nvvm-reflect-ftz", i32 1} | ||
| !1 = !{i32 4, !"nvvm-reflect-prec-sqrt", i32 1} |
There was a problem hiding this comment.
This line seem to be lost during pulldown (at least git log/blame doesn't show any patches explicitly removing it), so I'm restoring it here.
Signed-off-by: Sidorov, Dmitry <[email protected]>
MrSidims
changed the title
MrSidims
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
MrSidims
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
npmiller
reviewed
Feb 18, 2025
npmiller
reviewed
Feb 18, 2025
Signed-off-by: Sidorov, Dmitry <[email protected]>
MrSidims
changed the title
MrSidims
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Signed-off-by: Sidorov, Dmitry <[email protected]>
MrSidims
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
MrSidims
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/dpcpp-tools-reviewers @intel/dpcpp-clang-driver-reviewers please take a look |
mdtoguchi
approved these changes
Feb 20, 2025
npmiller
approved these changes
Feb 20, 2025
|
@mdtoguchi deprecation (or renaming of offload options) will be followed in #17033 also added description in the PR |
|
@intel/llvm-gatekeepers please help with merge not sure, if tools team approval is necessary here, the only file that slips to the 'default' owner is llvm/docs/NVPTXUsage.rst , but approval Nicolas in this regard is (IMHO) sufficient. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-foffload-fp32-prec-sqrt and -fsycl-fp32-prec-sqrt options should be merged together as they have the same purpose.
In this patch ability of -fsycl-fp32-prec-sqrt to pass appropriate options to CUDA and HIP compilers was added to
-foffload-fp32-prec-sqrt to allow such merge in the future.