[SYCL][UR] Improve header copy dependencies #17093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When copying the UR headers to `build/include` make sure that the `sycl-headers` target knowns about the dependencies upon the headers in `unified-runtime/include` and make sure that they are copied when changed. This should hopefully also stop occasional failures in CI: ``` In file included from /__w/llvm/llvm/src/unified-runtime/source/adapters/native_cpu/ur_interface_loader.cpp:11: /__w/llvm/llvm/build/include/ur_api.h:15: error: unterminated #ifndef ```
kbenzie
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kbenzie
changed the title
sergey-semenov
approved these changes
Feb 20, 2025
kbenzie
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kbenzie
added a commit
that referenced
this pull request
Mar 4, 2025
The `UR_EXTERNAL_DEPENDENCIES` option can be used to specify a list of CMake targets that all libraries and executables in the UR build should depend on, e.g. the `sycl-headers` target. Following on from #17093
github-actions bot
pushed a commit
to kbenzie/unified-runtime
that referenced
this pull request
Mar 5, 2025
The `UR_EXTERNAL_DEPENDENCIES` option can be used to specify a list of CMake targets that all libraries and executables in the UR build should depend on, e.g. the `sycl-headers` target. Following on from intel/llvm#17093
github-actions bot
pushed a commit
to kbenzie/unified-runtime
that referenced
this pull request
Mar 5, 2025
The `UR_EXTERNAL_DEPENDENCIES` option can be used to specify a list of CMake targets that all libraries and executables in the UR build should depend on, e.g. the `sycl-headers` target. Following on from intel/llvm#17093
github-actions bot
pushed a commit
to kbenzie/unified-runtime
that referenced
this pull request
Mar 5, 2025
The `UR_EXTERNAL_DEPENDENCIES` option can be used to specify a list of CMake targets that all libraries and executables in the UR build should depend on, e.g. the `sycl-headers` target. Following on from intel/llvm#17093
kbenzie
added a commit
to oneapi-src/unified-runtime
that referenced
this pull request
Mar 5, 2025
The `UR_EXTERNAL_DEPENDENCIES` option can be used to specify a list of CMake targets that all libraries and executables in the UR build should depend on, e.g. the `sycl-headers` target. Following on from intel/llvm#17093
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When copying the UR headers to
build/includemake sure that thesycl-headerstarget knowns about the dependencies upon the headers inunified-runtime/includeand make sure that they are copied when changed.This should hopefully also stop occasional failures in CI: