-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL][RTC] Add device library E2E test #17131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Julian Oppermann <[email protected]>
I plan to add tests for the |
// Only test the fp32 variants of complex, math and imf to keep this test | ||
// device-agnostic. | ||
|
||
// cl_intel_devicelib_math |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since ptr is {1, 1, 1, 1} it'd be nice to leave a comment here for each stating the expected value ( 0.8 1.4, 0, 1.4 right?)
I mention this because the test is failing on Windows with an 0xc0000409 error code, which is an assert() failure. AFAICT, the only assert added by this PR is the none of the new values of ptr[] are 1.0f.
Not sure what's going on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I added a comment and now print out the values. Curious to see what happens on Windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the end this was just a compilation error, due to the specific flavour of complex data type not being supported on Windows. I changed the test to use std::complex
instead. The reason why we didn't see this in the CI logs is that the default handler for uncaught exceptions doesn't seem to print anything on Windows 🤔
Signed-off-by: Julian Oppermann <[email protected]>
Signed-off-by: Julian Oppermann <[email protected]>
Signed-off-by: Julian Oppermann <[email protected]>
Signed-off-by: Julian Oppermann <[email protected]>
@cperkinsintel Could you have a second look, please? |
@intel/llvm-gatekeepers Please merge, thanks! |
New E2E test to exercise use of device libraries in an RTC kernel. Currently, the libraries are JIT-linked, i.e. their use is encoded in the
SYCL/devicelib req mask
property set, and the program manager loads and links the library.