-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL][RTC] Add device library E2E test #17131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1132468
[SYCL][RTC] Add device library E2E test
jopperm 4b6593d
Print results
jopperm 0253865
Merge remote-tracking branch 'upstream/sycl' into rtc-device-linking-e2e
jopperm fbd3fe7
Add Windows-specific device lib
jopperm 427d815
Appease CI's clang-format
jopperm f1ec306
Merge remote-tracking branch 'upstream/sycl' into rtc-device-linking-e2e
jopperm cb0b2c0
Use std::complex in test
jopperm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since ptr is {1, 1, 1, 1} it'd be nice to leave a comment here for each stating the expected value ( 0.8 1.4, 0, 1.4 right?)
I mention this because the test is failing on Windows with an 0xc0000409 error code, which is an assert() failure. AFAICT, the only assert added by this PR is the none of the new values of ptr[] are 1.0f.
Not sure what's going on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I added a comment and now print out the values. Curious to see what happens on Windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the end this was just a compilation error, due to the specific flavour of complex data type not being supported on Windows. I changed the test to use
std::complex
instead. The reason why we didn't see this in the CI logs is that the default handler for uncaught exceptions doesn't seem to print anything on Windows 🤔