-
Notifications
You must be signed in to change notification settings - Fork 788
[SYCL] Add implementation of host-interop-task and test. #1748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Add implementation of host-interop-task and test. #1748
Conversation
Signed-off-by: Sergey Kanaev <[email protected]>
Signed-off-by: Sergey Kanaev <[email protected]>
Signed-off-by: Sergey Kanaev <[email protected]>
a73440f
to
e04ea75
Compare
Signed-off-by: Sergey Kanaev <[email protected]>
Signed-off-by: Sergey Kanaev <[email protected]>
Signed-off-by: Sergey Kanaev <[email protected]>
Signed-off-by: Sergey Kanaev <[email protected]>
@Ruyk, @StuartDAdams I bet you know how to improve testing here. |
Some ideas:
cl_event userEvent = clCreateUserEvent(...)
q.submit([&](handler& ) {
h.codeplay_host_task([=](interop_handler& ih) {
clWaitForEvents(1, &userEvent);
}
});
clSetUserEventStatus(userEvent, CL_COMPLETE);
q.wait();
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff. Got a few comments on code style and a few things I'd like to clarify, but happy to see this ball rolling.
Signed-off-by: Sergey Kanaev <[email protected]>
…anaev/ht-interop-task-iface+impl
Signed-off-by: Sergey Kanaev <[email protected]>
Signed-off-by: Sergey Kanaev <[email protected]>
Signed-off-by: Sergey Kanaev <[email protected]>
Signed-off-by: Sergey Kanaev <[email protected]>
Signed-off-by: Sergey Kanaev <[email protected]>
@Ruyk, @StuartDAdams ping |
Signed-off-by: Sergey Kanaev <[email protected]>
Signed-off-by: Sergey Kanaev <[email protected]>
Signed-off-by: Sergey Kanaev <[email protected]>
Signed-off-by: Sergey Kanaev <[email protected]>
Signed-off-by: Sergey Kanaev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two really minor changes required for the CUDA backend to work, but they should not block this PR. It seems to work fine otherwise.
Are all the lit testing passing for you? host-task lit test sometimes deadlocks on my system,
|
Yes, that seems to fix the problem. |
Signed-off-by: Sergey Kanaev <[email protected]>
@StuartDAdams , @Ruyk the only latest changes are some stylistic ones. Please review and approve if you have no objections. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CUDA variant I have seems to work locally (bearing two minor changes), so looks good!
This patch is number two in series of patches for interop part of host task.
This patch introduces an API to enqueue host-task with
interop_handle
argumentSee the proposal [1].
Depends on #1937
[1] https://github.com/codeplaysoftware/standards-proposals/blob/master/host_task/host_task.md