[SYCL] Fix possible failure when enqueing only a single host-task #1937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-kanaev
force-pushed
the
private/s-kanaev/fix-possible-deadlock
branch
from
a650cac to
8b9f200
Compare
v-klochkov
reviewed
Jun 19, 2020
v-klochkov
reviewed
Jun 19, 2020
v-klochkov
reviewed
Jun 19, 2020
s-kanaev
force-pushed
the
private/s-kanaev/fix-possible-deadlock
branch
from
8b9f200 to
237f900
Compare
Signed-off-by: Sergey Kanaev <[email protected]>
s-kanaev
force-pushed
the
private/s-kanaev/fix-possible-deadlock
branch
from
237f900 to
463336e
Compare
added 2 commits
June 25, 2020 13:15
Signed-off-by: Sergey Kanaev <[email protected]>
Signed-off-by: Sergey Kanaev <[email protected]> Co-authored-by: Sergey Semenov <[email protected]>
Signed-off-by: Sergey Kanaev <[email protected]>
sergey-semenov
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue results in either segfault due to some nullptr dereference or in a deadlock when the buffer gets destroyed and the last access to it was through host task.