Skip to content

[CI] bump level-zero version #17485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2025
Merged

[CI] bump level-zero version #17485

merged 1 commit into from
Mar 18, 2025

Conversation

igchor
Copy link
Member

@igchor igchor commented Mar 17, 2025

This is a prerequisite for #17150

@igchor igchor requested a review from a team as a code owner March 17, 2025 14:50
@igchor igchor temporarily deployed to WindowsCILock March 17, 2025 14:50 — with GitHub Actions Inactive
"version": "v1.20.2",
"url": "https://github.com/oneapi-src/level-zero/releases/tag/v1.20.2",
"github_tag": "v1.21.2",
"version": "v1.21.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we care about Windows? If you PR is going to require the same L0 version on Windows, I need to first check that the latest released driver is using this L0 version, and if so, I need to update all the runners

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now that UR L0 is using the static loader, the version on the machines does not have to match the version used by UR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even the version being used in the driver running on the machine?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, what matters is the loader on the machine matches the version of the loader that is installed is the version the driver is paired with.

The version the UR is built with simply gives the UR the ability to support v1.21.2, but is fully backwards compatible.

There should be no compatibility issues, and in fact we don't want them to match in the CI because that will not be the traditional use case.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it, thanks

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, we want to update the version here because the validation layer for SYCL testing needs to be new such that the leak check is done in the L0 loader vs UR layers.

so, this change is needed to address that need. It will not cause an issue with the windows driver if this version of the loader is newer.

This is a prerequisite for intel#17150
@igchor
Copy link
Member Author

igchor commented Mar 18, 2025

There seem to be some CI failures; @sarnex, is there something I need to fix?

@sarnex
Copy link
Contributor

sarnex commented Mar 18, 2025

No I'll fix the install driver script again later

Is this ready for merge @igchor?

@igchor
Copy link
Member Author

igchor commented Mar 18, 2025

No I'll fix the install driver script again later

Is this ready for merge @igchor?

Yes, it's ready from my side.

@sarnex sarnex merged commit 3cd067a into intel:sycl Mar 18, 2025
28 of 31 checks passed
uditagarwal97 added a commit that referenced this pull request Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants