-
Notifications
You must be signed in to change notification settings - Fork 787
[CI] bump level-zero version #17485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] bump level-zero version #17485
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,9 +19,9 @@ | |
"root": "{DEPS_ROOT}/opencl/runtime/linux/oclgpu" | ||
}, | ||
"level_zero": { | ||
"github_tag": "v1.20.2", | ||
"version": "v1.20.2", | ||
"url": "https://github.com/oneapi-src/level-zero/releases/tag/v1.20.2", | ||
"github_tag": "v1.21.2", | ||
"version": "v1.21.2", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we care about Windows? If you PR is going to require the same L0 version on Windows, I need to first check that the latest released driver is using this L0 version, and if so, I need to update all the runners There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. now that UR L0 is using the static loader, the version on the machines does not have to match the version used by UR. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Even the version being used in the driver running on the machine? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes, what matters is the loader on the machine matches the version of the loader that is installed is the version the driver is paired with. The version the UR is built with simply gives the UR the ability to support v1.21.2, but is fully backwards compatible. There should be no compatibility issues, and in fact we don't want them to match in the CI because that will not be the traditional use case. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. got it, thanks There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. However, we want to update the version here because the validation layer for SYCL testing needs to be new such that the leak check is done in the L0 loader vs UR layers. so, this change is needed to address that need. It will not cause an issue with the windows driver if this version of the loader is newer. |
||
"url": "https://github.com/oneapi-src/level-zero/releases/tag/v1.21.2", | ||
"root": "{DEPS_ROOT}/opencl/runtime/linux/oclgpu" | ||
}, | ||
"tbb": { | ||
|
Uh oh!
There was an error while loading. Please reload this page.