[SYCL][NFC] Fix string comparison in handler.hpp #1761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not correct to compare c strings content using == operator.
s-kanaev
approved these changes
May 27, 2020
| @@ -411,7 +411,7 @@ class __SYCL_EXPORT handler { | |||
| using KI = sycl::detail::KernelInfo<KernelName>; | |||
| // Empty name indicates that the compilation happens without integration | |||
| // header, so don't perform things that require it. | |||
| if (KI::getName() != "") { | |||
There was a problem hiding this comment.
Compiler had put the same pointer here as in https://github.com/intel/llvm/blob/sycl/sycl/include/CL/sycl/detail/kernel_desc.hpp#L59 or https://github.com/intel/llvm/blob/sycl/sycl/include/CL/sycl/detail/kernel_desc.hpp#L68, didn't it?
There was a problem hiding this comment.
I guess so. But it is UB.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not correct to compare c strings content using == operator.