Skip to content

[SYCL][NFC] Fix string comparison in handler.hpp #1761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2020
Merged

[SYCL][NFC] Fix string comparison in handler.hpp #1761

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sycl/include/CL/sycl/handler.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,7 @@ class __SYCL_EXPORT handler {
using KI = sycl::detail::KernelInfo<KernelName>;
// Empty name indicates that the compilation happens without integration
// header, so don't perform things that require it.
if (KI::getName() != "") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiler had put the same pointer here as in https://github.com/intel/llvm/blob/sycl/sycl/include/CL/sycl/detail/kernel_desc.hpp#L59 or https://github.com/intel/llvm/blob/sycl/sycl/include/CL/sycl/detail/kernel_desc.hpp#L68, didn't it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess so. But it is UB.

if (KI::getName() != nullptr && KI::getName()[0] != '\0') {
MArgs.clear();
extractArgsAndReqsFromLambda(MHostKernel->getPtr(), KI::getNumParams(),
&KI::getParamDesc(0));
Expand Down