Skip to content

[SYCL][UR][L0 v2] Fix p2p access checking #17919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025
Merged

[SYCL][UR][L0 v2] Fix p2p access checking #17919

merged 1 commit into from
Apr 9, 2025

Conversation

igchor
Copy link
Member

@igchor igchor commented Apr 8, 2025

The order of arguments to zeDeviceCanAccessPeer was incorrect causing problems on platforms with both
discrete and integrated GPUs.

Relying on incorrecnt information zeContextMakeMemoryResident was being called for memory that was inaccesible on a device.

The order of arguments to zeDeviceCanAccessPeer was
incorrect causing problems on platforms with both
discrete and integrated GPUs.

Relying on incorrecnt information zeContextMakeMemoryResident
was being called for memory that was inaccesible on a device.
@igchor igchor requested a review from a team as a code owner April 8, 2025 22:21
@igchor igchor temporarily deployed to WindowsCILock April 8, 2025 22:21 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock April 8, 2025 22:40 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock April 8, 2025 22:40 — with GitHub Actions Inactive
@igchor
Copy link
Member Author

igchor commented Apr 9, 2025

@intel/llvm-gatekeepers this is ready to be merged

@kbenzie kbenzie merged commit bace529 into intel:sycl Apr 9, 2025
32 checks passed
KornevNikita pushed a commit that referenced this pull request May 27, 2025
The order of arguments to zeDeviceCanAccessPeer was incorrect causing
problems on platforms with both
discrete and integrated GPUs.

Relying on incorrecnt information zeContextMakeMemoryResident was being
called for memory that was inaccesible on a device.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants