-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL][NATIVECPU] use ur_memory_scope_capability_flags_t
in NativeCPU adapter
#18462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something seems to have gone in the last merge or rebase to re-trigger CI, this PR isn't supposed to have changes in 5000+ files
The thousands of files changed here are because of a force-push to the |
Replaced by #18537 |
@hvdijk Really sorry about this. Usually when merging the pulldowns, we rely on a bot/tool to do the merge automatically. Unforunately the bot was broken so we tried to do the pulldown merge but I messed it up and the tree was broken. We decided a force-push was the best way to fix the issue. In general we never want to force push, and it's blocked by default, it just had to be done to fix the bad manual merge. The root fix is getting the bot fixed so we never have to even try to merge manually, we've reached out to the team that owns it. I want to say force pushes should never happen, but in rare cases like this they may, but we're trying to prevent having to do them ever. Sorry again, and let me know if there's a way I can help. |
@sarnex Thanks, if it's only ever going to happen in extremely rare cases, that's okay. We needed some manual intervention on our end to restore the mirror, but we did get it working again, and @uwedolinsky was able to sort of restore this PR by creating it anew. |
Glad to hear, sorry again guys |
A fix for the NativeCPU adapter to use
ur_memory_scope_capability_flags_t
instead ofuint64_t
.Required for NativeCPU to pass
AtomicRef
-related e2e and SYCL-CTS tests.