-
Notifications
You must be signed in to change notification settings - Fork 787
LLVM and SPIRV-LLVM-Translator pulldown (WW19 2025) #18403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When parsing a function pointer typed field we use Parser::ParseTypeQualifierListOpt, but then drops subsequent type attributes and qualifiers unless explicitly handled. There is an existing solution for the _Atomic qualifier, and this PR simply extends that to __ptrauth for now. In future we may want to investigate a more robust mechanism to ensure type qualifiers are not silently dropped so that future type qualifiers do not suffer the same problem.
This reverts commit d431921. Missing gtests have been updated. Original message: This addresses an existing TODO and simply moves the current code to add canonical IV recipes to the initial skeleton construction, at the same place where the corresponding region will be introduced.
We can use StringRef for PassPrefix because it is used only with StringRef::starts_with.
Modify the unittest logic in offload to only look for `third-party/unittest` directory when `llvm_gtest` is not provided by LLVM itself (in-tree or installed). This makes it possible to run unittests in sparse checkouts without the `third-party/unittest` tree. While at it, also make sure `LLVM_THIRD_PARTY_DIR` is actually set while performing standalone builds. The logic is copied from `compiler-rt`. --------- Co-authored-by: Joseph Huber <[email protected]>
…(#138411) Note that orc::ExecutorAddr default-constructs itself with Addr being 0.
The new TableGen warning introduced in 951292b shows the following warnings: ``` warning: Processor ck807e contains duplicate feature 'edsp' warning: Processor ck807e contains duplicate feature 'dsp1e2' warning: Processor ck807e contains duplicate feature 'dspe60' warning: Processor ck807ef contains duplicate feature 'edsp' warning: Processor ck807ef contains duplicate feature 'dsp1e2' warning: Processor ck807ef contains duplicate feature 'dspe60' ```
15bb1db removed the last dependency on ILV, move the code out of ILV in preparation of consolidating in VPlanRecipes.cpp.
This fixes a warning where a variable assigned in 'if' statement wasn't referenced again.
It seems we were missing a dependency when adding a new test target, e.g., test libc.test.src.math.sqrt_test.__unit__ would create a custom target in the form of: ``` add_custom_target( libc.test.src.__support.FPUtil.dyadic_float_test.__unit__ COMMAND ${LIBC_UNITTEST_ENV} ${CMAKE_CROSSCOMPILING_EMULATOR} libc.test.src.__support.FPUtil.dyadic_float_test.__unit__.__build__ COMMENT Running unit test libc.test.src.__support.FPUtil.dyadic_float_test.__unit__ ) ``` but it wouldn't set that it depends on libc.test.src.__support.FPUtil.dyadic_float_test.__unit__.__build__ being built. For some reason, it would break the rv32 buildbot, as it would try to run a test but the __build__ is nowhere to be found, since it wasn't built in the first place.
Without it, certain functions such as dladdr are not make available by the headers. Signed-off-by: Jeremy Drake <[email protected]>
…8328) This is no longer necessary, and results in an inconvenient define of `i386` on i386 Cygwin targets which breaks compiling llvm/include/llvm/ExecutionEngine/JITLink/i386.h. Signed-off-by: Jeremy Drake <[email protected]>
GNU ld seems to ignore this option, but LLD treats the presence of this unknown option as an error.
... to align with other targets, e.g., https://reviews.llvm.org/D77853 (AArch64) and https://reviews.llvm.org/D83634 (AVR). binutils's sparc port uses %d when imm<=9, diverging from other ports. We do not follow the binutils sparc port behavior.
…location types Simplify code, which is enabled by 40789ce ("MCFixup: Move relocation values before FK_NONE")
….h. NFC Remove a fishy `#undef LoongArch` and an unneeded user-provided dtor.
As described in #136088 (for RISC-V), the `llvm-mc -show-encoding` output no longer displays descriptive fixup names. Just remove -show-encoding.
`call local` should perform STT_SECTION adjustment as well as `call .Ltmp0`. The early support 9fc2909 from 2014 was confused.
…itions Reviewers: brad0, rorth, s-barannikov Reviewed By: s-barannikov Pull Request: llvm/llvm-project#138398
From SPARC T3 Supplement to the UltraSPARC Architecture 2007 Specification: > T3 SPARC core has a new 9 stage floating point pipeline and added Fused > Multiply-Add (FMADD) instruction and VIS 3.0 Instructions compared to > UltraSPARC T2/T2+. Reviewers: rorth, s-barannikov, brad0 Reviewed By: s-barannikov Pull Request: llvm/llvm-project#138399
* Remove unuseful -filetype=asm -show-encoding output from relocation tests. * Test STT_TLS for TLS relocations * Test r_offset for a few relocations * Test ASM output for many relocations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PrintAsCanonical change looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsji offered to file an issue for tracking the unsupported HLSL tests.
Based on that, I am okay with this change.
@intel/llvm-gatekeepers This is ready for merge -- the failures in CI are unstable infra, they passed before https://github.com/intel/llvm/actions/runs/15058024714 (no related changes afterwards). |
/merge |
@DoyleLi Down again? |
Looks like this PD breaks the sycl_cts/bit_cast test - https://github.com/intel/llvm/actions/runs/15081117059/job/42398114254:
|
Should be due to KhronosGroup/SPIRV-LLVM-Translator@19d67bdfc9ebf8e Likely a real compiler bug exposed by llvm-spirv tools refactoring. @intel/dpcpp-spirv-reviewers Please get someone to have a look. Thanks. |
LLVM: llvm/llvm-project@d66dbd6
SPIRV-LLVM-Translator: KhronosGroup/SPIRV-LLVM-Translator@c3b8056