Skip to content

[SYCL] emit forward declaration of template specialization into integration header #18929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dklochkov-emb
Copy link
Contributor

This PR fixes bug with templated kernel free function and its specialization, i.e. forward declaration of specialization is emitted into integration header too.

@dklochkov-emb dklochkov-emb requested review from a team as code owners June 11, 2025 16:09
@dklochkov-emb dklochkov-emb self-assigned this Jun 11, 2025
@dklochkov-emb dklochkov-emb requested a review from lbushi25 June 11, 2025 16:09
Copy link
Contributor

@lbushi25 lbushi25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Fznamznon
Copy link
Contributor

CI fails seem related?

@dklochkov-emb
Copy link
Contributor Author

CI fails seem related?

@Fznamznon yes, it was related but I fixed.

@dklochkov-emb
Copy link
Contributor Author

@intel/llvm-gatekeepers please, merge it

@againull againull merged commit 7f76000 into intel:sycl Jun 17, 2025
37 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants