Skip to content

[SYCL][E2E] Remove unused command line arguments from tests #19141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025

Conversation

lbushi25
Copy link
Contributor

In follow up to an earlier PR, this PR removes the --save-temps option from 2 E2E tests where it is unused and causing errors in certain QA testing configurations. It is probably a remnant of local debugging.

@lbushi25 lbushi25 requested a review from a team as a code owner June 25, 2025 15:12
@lbushi25 lbushi25 requested a review from aelovikov-intel June 25, 2025 15:12
@aelovikov-intel
Copy link
Contributor

In follow up to an earlier PR, this PR removes the --save-temps option from 2 E2E tests where it is unused and causing errors in certain QA testing configurations. It is probably a remnant of local debugging.

@dklochkov-emb , can you confirm that it wasn't intended (looks like your #18929 added it).

@AlexeySachkov
Copy link
Contributor

In follow up to an earlier PR, this PR removes the --save-temps option from 2 E2E tests where it is unused and causing errors in certain QA testing configurations. It is probably a remnant of local debugging.

@dklochkov-emb , can you confirm that it wasn't intended (looks like your #18929 added it).

Even if it was intentional, it shouldn't be in e2e tests

@lbushi25
Copy link
Contributor Author

lbushi25 commented Jun 25, 2025

In follow up to an earlier PR, this PR removes the --save-temps option from 2 E2E tests where it is unused and causing errors in certain QA testing configurations. It is probably a remnant of local debugging.

@dklochkov-emb , can you confirm that it wasn't intended (looks like your #18929 added it).

He is on vacation, back next week. I agree with Alexey here. Not only is it unused, but he probably meant it to look at llvm IR files during debugging for which there are other more well supported options such as -emit-llvm

@lbushi25
Copy link
Contributor Author

@intel/llvm-gatekeepers This is ready for merge please!

@martygrant martygrant merged commit e6e1703 into intel:sycl Jun 25, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants