[SYCL][E2E] Cleanup DeviceImageDependencies unsupported #19016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature is not supported on CUDA and HIP. There was only one test without the unsupported directive, the `free_function_kernels.cpp` test, but this is also tested in `KernelAndProgram` without the image dependency flag and more thoroughly. So since the feature is unsupported anyway it makes sense to disable it as well.
maarquitos14
approved these changes
Jun 17, 2025
|
@intel/llvm-gatekeepers this is ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is not supported on CUDA and HIP.
There was only one test without the unsupported directive, the
free_function_kernels.cpptest, but this is also tested inKernelAndProgramwithout the image dependency flag and more thoroughly. So since the feature is unsupported anyway it makes sense to disable it as well.