Skip to content

[SYCL][E2E] Cleanup DeviceImageDependencies unsupported #19016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 17, 2025
Merged

[SYCL][E2E] Cleanup DeviceImageDependencies unsupported #19016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
84df032
[SYCL][E2E] Cleanup DeviceImageDependencies unsupported
npmiller Jun 17, 2025
59c5514
Merge branch 'sycl' into device-image
npmiller Jun 17, 2025
ec94b75
Merge branch 'sycl' into device-image
npmiller Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions sycl/test-e2e/DeviceImageDependencies/NewOffloadDriver/dynamic.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
// Test -fsycl-allow-device-image-dependencies with dynamic libraries.

// UNSUPPORTED: target-nvidia || target-amd
// UNSUPPORTED-INTENDED: Not implemented yet for Nvidia/AMD backends.

// DEFINE: %{dynamic_lib_options} = -fsycl %fPIC %shared_lib -fsycl-allow-device-image-dependencies -I %S/Inputs %if windows %{-DMAKE_DLL %}
// DEFINE: %{dynamic_lib_suffix} = %if windows %{dll%} %else %{so%}

Expand Down
2 changes: 0 additions & 2 deletions sycl/test-e2e/DeviceImageDependencies/NewOffloadDriver/math_device_lib.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
// REQUIRES: aspect-fp64
// UNSUPPORTED: target-amd || target-nvidia
// UNSUPPORTED-INTENDED: Not implemented yet for Nvidia/AMD backends.

// DEFINE: %{mathflags} = %if cl_options %{/clang:-fno-fast-math%} %else %{-fno-fast-math%}

Expand Down
3 changes: 0 additions & 3 deletions sycl/test-e2e/DeviceImageDependencies/NewOffloadDriver/objects.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
// Test -fsycl-allow-device-image-dependencies with objects.

// UNSUPPORTED: target-nvidia || target-amd
// UNSUPPORTED-INTENDED: Not implemented yet for Nvidia/AMD backends.

// RUN: %clangxx --offload-new-driver -fsycl %S/Inputs/a.cpp -I %S/Inputs -c -o %t_a.o
// RUN: %clangxx --offload-new-driver -fsycl %S/Inputs/b.cpp -I %S/Inputs -c -o %t_b.o
// RUN: %clangxx --offload-new-driver -fsycl %S/Inputs/c.cpp -I %S/Inputs -c -o %t_c.o
Expand Down
3 changes: 0 additions & 3 deletions sycl/test-e2e/DeviceImageDependencies/NewOffloadDriver/singleDynamicLibrary.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
// Test -fsycl-allow-device-image-dependencies with a single dynamic library on
// Windows and Linux.

// UNSUPPORTED: target-nvidia || target-amd
// UNSUPPORTED-INTENDED: Not implemented yet for Nvidia/AMD backends.

// RUN: %clangxx --offload-new-driver -fsycl %fPIC %shared_lib -fsycl-allow-device-image-dependencies -I %S/Inputs \
// RUN: %S/Inputs/a.cpp \
// RUN: %S/Inputs/b.cpp \
Expand Down
2 changes: 0 additions & 2 deletions sycl/test-e2e/DeviceImageDependencies/dynamic.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
// Test -fsycl-allow-device-image-dependencies with dynamic libraries.

// UNSUPPORTED: target-nvidia || target-amd

// DEFINE: %{dynamic_lib_options} = -fsycl %fPIC %shared_lib -fsycl-allow-device-image-dependencies -I %S/Inputs %if windows %{-DMAKE_DLL %}
// DEFINE: %{dynamic_lib_suffix} = %if windows %{dll%} %else %{so%}

Expand Down
3 changes: 0 additions & 3 deletions sycl/test-e2e/DeviceImageDependencies/dynamic_compress.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
// Test device image linking when using dynamic libraries when one of
// the device image is compressed and the other is not.

// UNSUPPORTED: target-nvidia || target-amd
// UNSUPPORTED-INTENDED: Linking using dynamic libraries is not supported on AMD
// and Nvidia.
// REQUIRES: zstd

// DEFINE: %{dynamic_lib_options} = -fsycl %fPIC %shared_lib -fsycl-allow-device-image-dependencies -I %S/Inputs %if windows %{-DMAKE_DLL %}
Expand Down
2 changes: 2 additions & 0 deletions sycl/test-e2e/DeviceImageDependencies/lit.local.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# Device image dependencies aren't supported on Nvidia and AMD
config.unsupported_features += ['target-nvidia', 'target-amd']
1 change: 0 additions & 1 deletion sycl/test-e2e/DeviceImageDependencies/math_device_lib.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// REQUIRES: aspect-fp64
// UNSUPPORTED: target-amd || target-nvidia

// DEFINE: %{mathflags} = %if cl_options %{/clang:-fno-fast-math%} %else %{-fno-fast-math%}

Expand Down
2 changes: 0 additions & 2 deletions sycl/test-e2e/DeviceImageDependencies/objects.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
// Test -fsycl-allow-device-image-dependencies with objects.

// UNSUPPORTED: target-nvidia || target-amd

// RUN: %clangxx -fsycl %S/Inputs/a.cpp -I %S/Inputs -c -o %t_a.o
// RUN: %clangxx -fsycl %S/Inputs/b.cpp -I %S/Inputs -c -o %t_b.o
// RUN: %clangxx -fsycl %S/Inputs/c.cpp -I %S/Inputs -c -o %t_c.o
Expand Down
2 changes: 0 additions & 2 deletions sycl/test-e2e/DeviceImageDependencies/singleDynamicLibrary.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Test -fsycl-allow-device-image-dependencies with a single dynamic library on Windows
// and Linux.

// UNSUPPORTED: target-nvidia || target-amd

// RUN: %clangxx -fsycl %fPIC %shared_lib -fsycl-allow-device-image-dependencies -I %S/Inputs \
// RUN: %S/Inputs/a.cpp \
// RUN: %S/Inputs/b.cpp \
Expand Down
6 changes: 1 addition & 5 deletions sycl/test/e2e_test_requirements/no-unsupported-without-info.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
// tests to match the required format and in that case you should just update
// (i.e. reduce) the number and the list below.
//
// NUMBER-OF-UNSUPPORTED-WITHOUT-INFO: 252
// NUMBER-OF-UNSUPPORTED-WITHOUT-INFO: 248
//
// List of improperly UNSUPPORTED tests.
// Remove the CHECK once the test has been properly UNSUPPORTED.
Expand Down Expand Up @@ -92,10 +92,6 @@
// CHECK-NEXT: Basic/kernel_info_attr.cpp
// CHECK-NEXT: Basic/submit_time.cpp
// CHECK-NEXT: DeprecatedFeatures/DiscardEvents/discard_events_using_assert.cpp
// CHECK-NEXT: DeviceImageDependencies/dynamic.cpp
// CHECK-NEXT: DeviceImageDependencies/math_device_lib.cpp
// CHECK-NEXT: DeviceImageDependencies/objects.cpp
// CHECK-NEXT: DeviceImageDependencies/singleDynamicLibrary.cpp
// CHECK-NEXT: DeviceLib/built-ins/printf.cpp
// CHECK-NEXT: DeviceLib/cmath-aot.cpp
// CHECK-NEXT: DeviceLib/imf_bfloat16_integeral_convesions.cpp
Expand Down