[Driver][SYCL][FPGA] Do not generate host dependency files by default #1918
Conversation
mdtoguchi
force-pushed
the
private/mdtoguchi/fpga-host-dep-changes
branch
from
c666117 to
f2a40d1
Compare
When compiling for -fsycl -fintelfpga, dependency file information needs to be generated and added to the AOT compilation step. The dep file is only needed from the device compilation. Remove the generation of the dependency files for the host compilation unless the user explicitly calls for it (with a generation option) Signed-off-by: Michael D Toguchi <[email protected]>
mdtoguchi
force-pushed
the
private/mdtoguchi/fpga-host-dep-changes
branch
from
f2a40d1 to
6a9cc5e
Compare
There was a problem hiding this comment.
Sorry for the late review, LGTM but for a minor comment.
One more thing, does the patch resolve the -foffload-static-lib issue with .d file extraction? If so, is this due to host dependency absence in a default fat object that no issues arise during the object's unbundling?
| SmallString<128> P(Inputs[0].getBaseInput()); | ||
| llvm::sys::path::replace_extension(P, "o"); | ||
| SmallString<128> Quoted; | ||
| QuoteTarget(llvm::sys::path::filename(P), Quoted); | ||
| CmdArgs.push_back(Args.MakeArgString(Quoted)); |
There was a problem hiding this comment.
Can we double-check these in the test?
There was a problem hiding this comment.
I'll adjust the test accordingly. As for your -foffload-static-lib issue with .d question, this patch does not address that problem. For that problem, we need to extract the .d files from the archive and add them to the aoc call. Current device extraction only takes into account the device objects and passes them along to the partial link step. The .d files are left alone.
There was a problem hiding this comment.
I suppose this also affects offload static library that are passed without this flag?
There was a problem hiding this comment.
@meiyacha, that is correct. Offload static lib w/ and w/out -foffload-static-lib behaves the same.
…file gen Signed-off-by: Michael D Toguchi <[email protected]>
When compiling for -fsycl -fintelfpga, dependency file information needs
to be generated and added to the AOT compilation step. The dep file is
only needed from the device compilation.
Remove the generation of the dependency files for the host compilation
unless the user explicitly calls for it (with a generation option)
Signed-off-by: Michael D Toguchi [email protected]