Skip to content

[Driver][SYCL] Correcting a sanitizer fail with null pointer #2008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 7, 2020
Merged

[Driver][SYCL] Correcting a sanitizer fail with null pointer #2008

merged 2 commits into from
Jul 7, 2020

Conversation

hchilama
Copy link
Contributor

The pull request "#1965" is closed, had some issues with the update. So created new one sorry for the inconvenience

@hchilama
Copy link
Contributor Author

To the comment from mdtoguchi in the 1965 pull request:
We already have a test that covers the execution path of this code change. The test is in the file llvm/clang/test/Driver/sycl-offload-static-lib.cpp

Test:
/// test behaviours of -foffload-static-lib=
//RUN: touch %t.a
//RUN: touch %t.o
//RUN: %clangxx-target x86_64-unknown-linux-gnu -fsycl -L/dummy/dir -foffload-static-lib=%
t.a -### %t.0 2>&1 \

mdtoguchi
mdtoguchi reviewed Jul 1, 2020
View reviewed changes
@hchilama hchilama requested a review from mdtoguchi July 1, 2020 20:04
@hchilama
Copy link
Contributor Author

hchilama commented Jul 2, 2020

Additional change for OffloadAction

mdtoguchi
mdtoguchi reviewed Jul 2, 2020
View reviewed changes
@hchilama hchilama requested a review from mdtoguchi July 2, 2020 22:09
mdtoguchi
mdtoguchi reviewed Jul 2, 2020
View reviewed changes
@hchilama hchilama requested a review from mdtoguchi July 3, 2020 01:37
mdtoguchi
mdtoguchi reviewed Jul 3, 2020
View reviewed changes
Copy link
Contributor

@mdtoguchi mdtoguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, I'd like @AGindinson to have a look.

AGindinson
AGindinson reviewed Jul 3, 2020
View reviewed changes
@hchilama hchilama requested review from mdtoguchi and AGindinson July 5, 2020 20:50
AGindinson
AGindinson previously approved these changes Jul 6, 2020
View reviewed changes
@hchilama
[Driver][SYCL] Correcting a sanitizer fail with null pointer
5a04194 
applied clang-format

Signed-off-by: Harini Chilamantula <[email protected]>
@hchilama hchilama requested a review from AGindinson July 6, 2020 21:21
AGindinson
AGindinson approved these changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@AGindinson AGindinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bader bader merged commit 5b92602 into intel:sycl Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AGindinson AGindinson AGindinson approved these changes

@elizabethandrews elizabethandrews Awaiting requested review from elizabethandrews

@Fznamznon Fznamznon Awaiting requested review from Fznamznon

@premanandrao premanandrao Awaiting requested review from premanandrao

@mdtoguchi mdtoguchi Awaiting requested review from mdtoguchi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hchilama @AGindinson @mdtoguchi @bader