[SYCL][CUDA] Fix event profiling queries #2034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return the correct PI API error code when trying to query events for commands on queues that have not enabled profiling. Signed-off-by: Bjoern Knafla <[email protected]>
smaslov-intel
approved these changes
Jul 6, 2020
| @@ -2703,6 +2703,11 @@ pi_result cuda_piEventGetProfilingInfo(pi_event event, | |||
|
|
|||
| assert(event != nullptr); | |||
|
|
|||
| pi_queue queue = event->get_queue(); | |||
| if (queue == nullptr || !(queue->properties_ & PI_QUEUE_PROFILING_ENABLE)) { | |||
There was a problem hiding this comment.
are you sure we should return this error when queue is null? what is the event without an associated queue?
There was a problem hiding this comment.
Only user events do not have queues associated with them - and while we do not support user events, this is the error code returned when trying to get performance data from one.
bjoernknafla
deleted the
bjoern/fix-cuda-pieventgetprofilinginfo-with-disabled-profiling
branch
jsji
pushed a commit
that referenced
this pull request
Jun 8, 2023
Flags operand is not optional, fill it with DebugInfoNone value (see #1965 for clarifications why it could not be generated by clang or by LLVM environment). Original commit: KhronosGroup/SPIRV-LLVM-Translator@7a54cde
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return the correct PI API error code when trying to query events for
commands on queues that have not enabled profiling.
Signed-off-by: Bjoern Knafla [email protected]