Skip to content

[Driver][SYCL]Suppress non-beneficial warning message when building with -fin… #2035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 17, 2020
Merged

[Driver][SYCL]Suppress non-beneficial warning message when building with -fin… #2035

merged 7 commits into from
Jul 17, 2020

Conversation

jinge90
Copy link
Contributor

@jinge90 jinge90 commented Jul 3, 2020

…telfpga -fsycl-link

Signed-off-by: gejin [email protected]

mdtoguchi
mdtoguchi reviewed Jul 3, 2020
View reviewed changes
Copy link
Contributor

@mdtoguchi mdtoguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test?

@jinge90
Copy link
Contributor Author

jinge90 commented Jul 10, 2020

Hi, @mdtoguchi
I have updated the tests based on your suggestion, thank you very much!

mdtoguchi
mdtoguchi reviewed Jul 15, 2020
View reviewed changes
mdtoguchi
mdtoguchi reviewed Jul 16, 2020
View reviewed changes
@mdtoguchi
Copy link
Contributor

Please update commit message to be [Driver][SYCL]

@jinge90 jinge90 changed the title [SYCL]Suppress non-beneficial warning message when building with -fin… [Driver][SYCL]Suppress non-beneficial warning message when building with -fin… Jul 16, 2020
@DoyleLi
Copy link
Contributor

DoyleLi commented Jul 16, 2020

[Comment from Xiaodong.Li] Please ignore this comment. It is used to test "on-demand" testing.
/summary:run

mdtoguchi
mdtoguchi reviewed Jul 16, 2020
View reviewed changes
mdtoguchi
mdtoguchi approved these changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@mdtoguchi mdtoguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bader bader merged commit 4522237 into intel:sycl Jul 17, 2020
@jinge90 jinge90 deleted the Suppress_non_beneficial_warning branch January 26, 2021 01:18
Chenyang-L pushed a commit that referenced this pull request Jul 11, 2023
@jcranmer-intel @Chenyang-L
Fix @llvm.annotation translation with opaque pointers enabled. (#2035)
7066bb9 
Original commit:
KhronosGroup/SPIRV-LLVM-Translator@f751ba1
jsji pushed a commit that referenced this pull request Jul 17, 2023
@jcranmer-intel @sys-ce-bb
Fix @llvm.annotation translation with opaque pointers enabled. (#2035)
fdcee20 
Original commit:
KhronosGroup/SPIRV-LLVM-Translator@f751ba1
jsji pushed a commit that referenced this pull request Aug 11, 2023
@jcranmer-intel @jsji
Fix @llvm.annotation translation with opaque pointers enabled. (#2035)
ad56aea 
Original commit:
KhronosGroup/SPIRV-LLVM-Translator@f751ba1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdtoguchi mdtoguchi mdtoguchi approved these changes

@AGindinson AGindinson Awaiting requested review from AGindinson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jinge90 @mdtoguchi @DoyleLi @bader