Skip to content

[Driver][SYCL]Suppress non-beneficial warning message when building with -fin… #2035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 17, 2020
Merged

[Driver][SYCL]Suppress non-beneficial warning message when building with -fin… #2035

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3cdd498
[SYCL]Suppress non-beneficial warning message when building with -fin…
jinge90 Jul 3, 2020
afbdf7a
Add test for suppressing LNK4221
jinge90 Jul 10, 2020
b04af6d
Update test for LNK4221 suppress
jinge90 Jul 10, 2020
6a97acb
remove unused code in test
jinge90 Jul 10, 2020
0b79ce4
Fix x86_64-windows-pc-msvc in test
jinge90 Jul 16, 2020
df6f7de
Little adjustment to x86_64-pc-windows-msvc targets
jinge90 Jul 16, 2020
7f4be53
Additional allocation not needed with string literal
jinge90 Jul 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions clang/lib/Driver/ToolChains/MSVC.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,9 @@ void visualstudio::Linker::constructMSVCLibCommand(Compilation &C,
}
CmdArgs.push_back(II.getFilename());
}
if (Args.hasArg(options::OPT_fsycl_link_EQ) &&
Args.hasArg(options::OPT_fintelfpga))
CmdArgs.push_back(C.getArgs().MakeArgString(Twine("/IGNORE:4221")));
CmdArgs.push_back(
C.getArgs().MakeArgString(Twine("-OUT:") + Output.getFilename()));

Expand Down
6 changes: 6 additions & 0 deletions clang/test/Driver/suppress_LNK4221_intelfpga_sycl-link.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
// REQUIRES: system-windows
// RUN: %clangxx -target x86_64-pc-windows-msvc -fsycl -fintelfpga -fsycl-link -Xshardware %s -### 2>&1 \
// RUN: | FileCheck %s
// RUN: %clang_cl -target x86_64-pc-windows-msvc -fsycl -fintelfpga -fsycl-link -Xshardware %s -### 2>&1 \
// RUN: | FileCheck %s
// CHECK: /IGNORE:4221