[SYCL] Make kernel impl non copyable and non movable. #2050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, what is the motivation for this change? Why kernel_impl must not be copied/moved? Thanks. |
|
The destructor for the kernel_impl class assumes that the proper constructor is called. If the object was created using a default copy constructor, it would call the destructor which expected the complementary PI_CALL in the constructor. |
v-klochkov
reviewed
Jul 8, 2020
sycl/source/detail/kernel_impl.hpp
Outdated
Comment on lines
150
to
151
| // This section means the object is non-movable and non-copyable | ||
| kernel_impl(const kernel_impl &) = delete; |
There was a problem hiding this comment.
I suggest 2 things:
- to move this section to the place right after the kernel_impl constructors declarations
- to add a simple comment explaining why they are non-movable. For example:
Suggested change
| // This section means the object is non-movable and non-copyable | |
| kernel_impl(const kernel_impl &) = delete; | |
| // There is no need in move and copy constructors. | |
| // If they are even needed they must call piKernelRetain method for MKernel. | |
| kernel_impl(const kernel_impl &) = delete; |
added 2 commits
July 16, 2020 08:46
This change delete the copy constructor and move constructor from the kernel impl classes. Signed-off-by: sarathnandu <[email protected]>
sarathnandu
force-pushed
the
rem_impl_cpy_cnstr
branch
from
2a71fe3 to
79128dc
Compare
Signed-off-by: sarathnandu <[email protected]>
v-klochkov
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change delete the copy constructor and move constructor
from the kernel impl classes.
Signed-off-by: sarathnandu [email protected]