Skip to content

[SYCL][CUDA] Fix byte-offset issue in libclc Image Support for CUDA #2068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2020
Merged

[SYCL][CUDA] Fix byte-offset issue in libclc Image Support for CUDA #2068

merged 1 commit into from
Jul 8, 2020

Conversation

nyalloc
Copy link
Contributor

@nyalloc nyalloc commented Jul 8, 2020

Offset was erroneously expressed in bits. This PR expresses the offset in bytes.

@nyalloc nyalloc requested a review from bader as a code owner July 8, 2020 15:20
@bader bader added cuda CUDA back-end libclc libclc project related issues labels Jul 8, 2020
@bader bader merged commit 24af4d8 into intel:sycl Jul 8, 2020
nyalloc added a commit to nyalloc/llvm that referenced this pull request Jul 14, 2020
@nyalloc
Revert "[SYCL][CUDA] Fix byte-offset issue in libclc Image Support fo…
30437ba 
…r CUDA (intel#2068)"

This reverts commit 24af4d8.
bader pushed a commit that referenced this pull request Jul 15, 2020
@nyalloc
Revert "[SYCL][CUDA] Fix byte-offset issue in libclc Image Support fo…
c3cba62 
…r CUDA (#2068)" (#2109)

This reverts commit 24af4d8.

The fix here is to express the size of an object in bytes, not bits. 24af4d8 was a mistake - the fix was already merged. 24af4d8 returns the code to the broken state. This commit reverts it and puts back in the fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bader bader bader approved these changes

Assignees
No one assigned
Labels
cuda CUDA back-end libclc libclc project related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nyalloc @bader