Skip to content

[SYCL][CUDA] Fix byte-offset issue in libclc Image Support for CUDA #2109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2020
Merged

[SYCL][CUDA] Fix byte-offset issue in libclc Image Support for CUDA #2109

merged 1 commit into from
Jul 15, 2020

Conversation

nyalloc
Copy link
Contributor

@nyalloc nyalloc commented Jul 14, 2020

This reverts commit 24af4d8.

@nyalloc nyalloc requested a review from bader as a code owner July 14, 2020 11:52
@bader bader added the cuda CUDA back-end label Jul 14, 2020
@bader
Copy link
Contributor

bader commented Jul 14, 2020 •
edited
Loading

@StuartDAdams, could you clarify why this change is being reverted, please?

@bader bader linked an issue Jul 15, 2020 that may be closed by this pull request
[SYCL][CUDA] Link error will happen with '-g' compiling option #2120
Closed
@bader bader mentioned this pull request Jul 15, 2020
Closed
@nyalloc
Copy link
Contributor Author

nyalloc commented Jul 15, 2020 •
edited
Loading

@StuartDAdams, could you clarify what this change is being reverted, please?

The fix here is to express the size of an object in bytes, not bits. 24af4d8 was a mistake - the fix was already merged. 24af4d8 returns the code to the broken state. This PR reverts it and puts back in the fix 😄

@bader bader merged commit c3cba62 into intel:sycl Jul 15, 2020
@bader
Copy link
Contributor

bader commented Jul 15, 2020

@StuartDAdams, could you clarify what this change is being reverted, please?

The fix here is to express the size of an object in bytes, not bits. 24af4d8 was a mistake - the fix was already merged. 24af4d8 returns the code to the broken state. This PR reverts it and puts back in the fix 😄

Thanks for clarification. I've added it to the commit message.

jsji pushed a commit that referenced this pull request Aug 11, 2023
@wenju-he @jsji
Fix delete of functions that becomes unused (#2109)
7a4574a 
After the first loop of deleting instructions in ValuesToDelete, deleted
instructions in ValuesToDelete are in an unstable state. Then in the
second loop of deleting, dyn_cast to GlobalValue could return true for
an instruction and double eraseFromParent causes crash.

Global values in ValuesToDelete are functions. Unused functions are
deleted by eraseUselessFunctions anyway.

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@aea1ac7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bader bader bader approved these changes

Assignees
No one assigned
Labels
cuda CUDA back-end
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SYCL][CUDA] Link error will happen with '-g' compiling option
2 participants
@nyalloc @bader