[SYCL] Fix crash when kernel object field is an array of structs #2083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds a 'top-level' struct InitListExpr for each element of a struct array. This is required to nest the InitListExprs of data members of each struct element correctly under the corresponding struct element. Signed-off-by: Elizabeth Andrews <[email protected]>
elizabethandrews
requested review from
Fznamznon and
premanandrao
as code owners
Signed-off-by: Elizabeth Andrews <[email protected]>
rdeodhar
reviewed
Jul 10, 2020
Also removed unnecessary check. Signed-off-by: Elizabeth Andrews <[email protected]>
erichkeane
reviewed
Jul 10, 2020
Fznamznon
previously approved these changes
Jul 10, 2020
Signed-off-by: Elizabeth Andrews <[email protected]>
Fznamznon
previously approved these changes
Jul 10, 2020
Signed-off-by: Elizabeth Andrews <[email protected]>
erichkeane
previously approved these changes
Jul 10, 2020
Fznamznon
previously approved these changes
Jul 10, 2020
|
Not sure why Jenkins builds are failing, especially since they all passed for previous commit. RHEL build failed with error Linux build and test failed for |
Signed-off-by: Elizabeth Andrews <[email protected]>
elizabethandrews
dismissed stale reviews from Fznamznon and erichkeane
via
88116ba
|
Guess the fails were infrastructure related..Tests all pass now and latest commit didn't add any code. |
premanandrao
approved these changes
Jul 14, 2020
jsji
pushed a commit
that referenced
this pull request
Aug 11, 2023
It should be compiltely rewritten Signed-off-by: Sidorov, Dmitry <[email protected]> Original commit: KhronosGroup/SPIRV-LLVM-Translator@0e3404e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a 'top-level' struct InitListExpr for each element
of a struct array. This is required to nest the InitListExprs of data
members of each struct element correctly under the corresponding struct
element.
Signed-off-by: Elizabeth Andrews [email protected]