Skip to content

[SPIR-V] Update SPV_INTEL_function_pointers extension #2254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SPIR-V] Update SPV_INTEL_function_pointers extension #2254

wants to merge 1 commit into from

Conversation

zuban32
Copy link
Contributor

@zuban32 zuban32 commented Aug 4, 2020

Replace OpFunctionPointerINTEL with a constant one

AlexeySachkov
AlexeySachkov reviewed Aug 4, 2020
View reviewed changes
@zuban32
[SPIR-V] Update SPV_INTEL_function_pointers extension
4477198 
Replace OpFunctionPointerINTEL with a constant one
@zuban32 zuban32 requested a review from a team as a code owner August 4, 2020 17:25
@zuban32 zuban32 mentioned this pull request Aug 4, 2020
Merged
AlexeySachkov
AlexeySachkov approved these changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@AlexeySachkov AlexeySachkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bader bader added the spec extension All issues/PRs related to extensions specifications label Aug 5, 2020
@AlexeySachkov
Copy link
Contributor

@intel/dpcpp-specification-reviewers, any feedback?

@bader
Copy link
Contributor

bader commented Oct 14, 2020

@intel/dpcpp-specification-reviewers, please, take a look.

@bader bader added the SPIR-V Issues related to SPIRV-LLVM-Translator label Feb 12, 2021
@bader
Copy link
Contributor

bader commented Jan 12, 2022

@zuban32, could you resolve merge conflicts, please?

@bader bader requested a review from AlexeySachkov January 13, 2022 17:54
@bader
Copy link
Contributor

bader commented Jan 26, 2022

@zuban32, could you resolve merge conflicts, please?

@zuban32, ping.

@AlexeySachkov AlexeySachkov mentioned this pull request Feb 7, 2022
Merged
AlexeySachkov
AlexeySachkov requested changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@AlexeySachkov AlexeySachkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should be superseded in favor of #4483 per my comment there

@github-actions github-actions bot added the Stale label Aug 7, 2022
@github-actions github-actions bot closed this Sep 6, 2022
jsji pushed a commit that referenced this pull request Dec 21, 2023
@VyacheslavLevytskyy @sys-ce-bb
Add validation and support for non-default address space in global va…
4061d4f 
…riables, and fix tests by adding explicit address space (#2254)

* report error when global variable has Function storage class
* validate and support non-default address space in global variables and fix related tests to conform with spirv-val rules
* fix order of checks
* apply code review suggestions

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@28c8935
Chenyang-L pushed a commit that referenced this pull request Feb 18, 2025
@callumfare
Merge pull request #2254 from PietroGhg/pietro/events_rr
18bc9e6 
[NATIVECPU] Implement events on Native CPU
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexeySachkov AlexeySachkov AlexeySachkov requested changes

Assignees
No one assigned
Labels
spec extension All issues/PRs related to extensions specifications SPIR-V Issues related to SPIRV-LLVM-Translator Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zuban32 @AlexeySachkov @bader