Skip to content

[SPIR-V][DOC] Update SPV_INTEL_function_pointers #4883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 12, 2022

Conversation

MrSidims
Copy link
Contributor

@MrSidims MrSidims commented Nov 3, 2021

OpFunctionPointerINTEL was renamed to OpConstantFunctionPointerINTEL

SPIR-V to LLVM IR Translator update: KhronosGroup/SPIRV-LLVM-Translator#1265
SPIR-V Headers update: KhronosGroup/SPIRV-Headers#251
SPIR-V Tools update: KhronosGroup/SPIRV-Tools#4613

Signed-off-by: Dmitry Sidorov [email protected]

OpFunctionPointerINTEL was renamed to OpConstantFunctionPointerINTEL

Signed-off-by: Dmitry Sidorov <[email protected]>
@MrSidims MrSidims added SPIR-V Issues related to SPIRV-LLVM-Translator Documentation Missing documentation for the code, compiler or runtime features, etc. labels Nov 3, 2021
@AlexeySachkov
Copy link
Contributor

@MrSidims, @AlexeySotkin, we need to incorporate #2254 into this PR: we need to list Alex Bezzubikov as a contributor and copy issues raised in that PR into the spec. The rest should come from this PR, i.e. ultimately we should have OpConstant* spelling for new instructions, but we shouldn't forget about contributors and discussions which happened during an intermediate step (OpConst* spelling)

@github-actions github-actions bot added the Stale label Aug 7, 2022
@MrSidims MrSidims requested a review from a team as a code owner August 10, 2022 13:11
@AlexeySachkov AlexeySachkov merged commit a29c74f into intel:sycl Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Missing documentation for the code, compiler or runtime features, etc. SPIR-V Issues related to SPIRV-LLVM-Translator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants