Skip to content

[Driver][SYCL] Enable Dead Parameter Elimination Optimization #2340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mdtoguchi
Copy link
Contributor

This is enabled by default for -fsycl, and can be disabled via the
-fno-sycl-early-optimizations switch.

Signed-off-by: Michael D Toguchi [email protected]

@mdtoguchi mdtoguchi requested a review from AGindinson as a code owner August 18, 2020 23:07
@mdtoguchi mdtoguchi requested a review from a team as a code owner August 19, 2020 14:06
@mdtoguchi mdtoguchi requested a review from v-klochkov August 19, 2020 14:06
Copy link
Contributor

@AGindinson AGindinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The driver changes mostly LGTM, assuming I've understood the whole DAE thing correctly. Could some more tests be added for -fno-sycl-early-optimizations?

mdtoguchi and others added 7 commits August 20, 2020 09:30
This is enabled by default for -fsycl, and can be disabled via the
-fno-sycl-early-optimizations switch.

Signed-off-by: Michael D Toguchi <[email protected]>
Behavior is now off by default.  Added support for -fsycl-dead-args-optimization
to control enabling.  Also updated tests to use option to exercise
the optimization.
@mdtoguchi mdtoguchi force-pushed the private/mdtoguchi/dead-paramemter-elim-opt-enable branch from 61502a5 to f9b664b Compare August 20, 2020 18:12
@mdtoguchi mdtoguchi requested a review from AGindinson August 21, 2020 00:17
@bader bader requested a review from AGindinson August 21, 2020 09:43
@bader bader merged commit f53ede9 into intel:sycl Aug 21, 2020
Chenyang-L pushed a commit that referenced this pull request Feb 18, 2025
Restore specific test to CL kernel match file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants