-
Notifications
You must be signed in to change notification settings - Fork 787
[Driver][SYCL] Enable Dead Parameter Elimination Optimization #2340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bader
merged 10 commits into
intel:sycl
from
mdtoguchi:private/mdtoguchi/dead-paramemter-elim-opt-enable
Aug 21, 2020
Merged
[Driver][SYCL] Enable Dead Parameter Elimination Optimization #2340
bader
merged 10 commits into
intel:sycl
from
mdtoguchi:private/mdtoguchi/dead-paramemter-elim-opt-enable
Aug 21, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AGindinson
reviewed
Aug 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The driver changes mostly LGTM, assuming I've understood the whole DAE thing correctly. Could some more tests be added for -fno-sycl-early-optimizations
?
This is enabled by default for -fsycl, and can be disabled via the -fno-sycl-early-optimizations switch. Signed-off-by: Michael D Toguchi <[email protected]>
Signed-off-by: Sergey Semenov <[email protected]>
Behavior is now off by default. Added support for -fsycl-dead-args-optimization to control enabling. Also updated tests to use option to exercise the optimization.
61502a5
to
f9b664b
Compare
AGindinson
reviewed
Aug 21, 2020
bader
approved these changes
Aug 21, 2020
AGindinson
approved these changes
Aug 21, 2020
romanovvlad
approved these changes
Aug 21, 2020
jsji
pushed a commit
that referenced
this pull request
Feb 15, 2024
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
Restore specific test to CL kernel match file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is enabled by default for -fsycl, and can be disabled via the
-fno-sycl-early-optimizations switch.
Signed-off-by: Michael D Toguchi [email protected]