[SYCL] [L0 PI] Added an assert to piEnqueueKernelLaunch() when the GlobalWorkOffset!=0. #2410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GlobalWorkOffset is not currently supported in Level Zero. Now the function will assert if someone tries to use it. Signed-off-by: Gail Lyons <[email protected]>
smaslov-intel
suggested changes
Sep 2, 2020
| @@ -2614,6 +2614,7 @@ piEnqueueKernelLaunch(pi_queue Queue, pi_kernel Kernel, pi_uint32 WorkDim, | |||
| assert(Kernel); | |||
| assert(Queue); | |||
| assert((WorkDim > 0) && (WorkDim < 4)); | |||
| assert(GlobalWorkOffset[0] == 0); | |||
There was a problem hiding this comment.
Why don't you check the other dimensions too? And also it can be NULL (actually I expect it to be NULL most of times). See here for the semantics of this argument: https://www.khronos.org/registry/OpenCL/sdk/2.2/docs/man/html/clEnqueueNDRangeKernel.html
Signed-off-by: Gail Lyons <[email protected]>
Signed-off-by: Gail Lyons <[email protected]>
smaslov-intel
previously approved these changes
Sep 3, 2020
The global work offset is not supported on level zero today. I am adding an assertion to piEnqueueKernelLaunch() to catch when the global work offset is not zero. This test uses the global work offset, so I am indicating that it will fail. Signed-off-by: Gail Lyons <[email protected]>
|
@glyons-intel pre-commit testing has reported issues, please, fix. |
Signed-off-by: Gail Lyons <[email protected]>
Signed-off-by: Gail Lyons <[email protected]>
smaslov-intel
approved these changes
Sep 17, 2020
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
…_eviction_and_caching [L0] Fix cached and evicted timestamp recordings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GlobalWorkOffset is not currently supported in Level Zero.
Now the function will assert if someone tries to use it.
Signed-off-by: Gail Lyons [email protected]