Skip to content

[SYCL] [L0 PI] Added an assert to piEnqueueKernelLaunch() when the GlobalWorkOffset!=0. #2410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 22, 2020
Merged

[SYCL] [L0 PI] Added an assert to piEnqueueKernelLaunch() when the GlobalWorkOffset!=0. #2410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ba2816a
Added an assert to piEnqueueKernelLaunch() when the GlobalWorkOffset!=0.
glyons-intel Sep 2, 2020
183585c
Incorporating code review comments
glyons-intel Sep 2, 2020
56167e1
Incorporating code review comments
glyons-intel Sep 2, 2020
b3bc848
Merge remote-tracking branch 'upstream/sycl' into glyons/offset
glyons-intel Sep 8, 2020
3538c2d
Indicate that this test is expected to fail on level_zero.
glyons-intel Sep 8, 2020
d7c124c
Merge remote-tracking branch 'upstream/sycl' into glyons/offset
glyons-intel Sep 12, 2020
0812f41
Reverting my patch to debug a windows testing issue.
glyons-intel Sep 16, 2020
736fe4a
Reimplementing my patch.
glyons-intel Sep 17, 2020
9faff66
Merge remote-tracking branch 'origin/sycl' into offset
againull Sep 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions sycl/plugins/level_zero/pi_level_zero.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2844,6 +2844,11 @@ piEnqueueKernelLaunch(pi_queue Queue, pi_kernel Kernel, pi_uint32 WorkDim,
assert(Kernel);
assert(Queue);
assert((WorkDim > 0) && (WorkDim < 4));
if (GlobalWorkOffset != NULL) {
for (pi_uint32 i = 0; i < WorkDim; i++) {
assert(GlobalWorkOffset[i] == 0);
}
}

ze_group_count_t ZeThreadGroupDimensions{1, 1, 1};
uint32_t WG[3];
Expand Down
3 changes: 3 additions & 0 deletions sycl/test/basic_tests/free_function_queries/free_function_queries.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@
// RUN: %CPU_RUN_PLACEHOLDER %t.out
// RUN: %GPU_RUN_PLACEHOLDER %t.out

// TODO: Support global work offset on Level Zero.
// XFAIL: level_zero

//==- free_function_queries.cpp - SYCL free function queries test -=//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
Expand Down