[SYCL] Emit a warning message for legacy env vars #2506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are deprecating legacy env vars SYCL_BE and SYCL_DEVICE_TYPE. This PR is intended to inform users about this change during the grace period. Signed-off-by: Byoungro So <[email protected]>
sycl/source/detail/pi.cpp
Outdated
| // env vars. | ||
| // Emit the deprecation warning message if SYCL_BE or SYCL_DEVICE_TYPE is | ||
| // set. | ||
| if (SYCLConfig<SYCL_BE>::get() || getenv("SYCL_DEVICE_TYPE")) { |
There was a problem hiding this comment.
Wouldn't it be better to move this code to where these templates are specialized, i.e. in source/detail/config.hpp? There is already needed logic there to only print it once.
There was a problem hiding this comment.
I need to check both SYCL_BE and SYCL_DEVICE_TYPE.
Config.hpp only handles SYCL_BE.
Note that this patch only lives a few releases until we really remove the support for SYCL_BE and SYCL_DEVICE_TYPE.
After removal, I will also remove this patch from pi.cpp.
There was a problem hiding this comment.
Done. I moved the warning message code into config.hpp.
also, fixed some minor bugs in device selectors. Signed-off-by: Byoungro So <[email protected]>
Signed-off-by: Byoungro So <[email protected]>
Signed-off-by: Byoungro So <[email protected]>
smaslov-intel
approved these changes
Sep 22, 2020
iclsrc
pushed a commit
that referenced
this pull request
Apr 25, 2024
Since SPIR-V 1.6 may be used with `OpFNegate` and with the binary floating-point comparison instructions (including `OpOrdered` and `OpUnordered`). Original commit: KhronosGroup/SPIRV-LLVM-Translator@6b47e8c4f79aa23
kbenzie
added a commit
to kbenzie/intel-llvm
that referenced
this pull request
Feb 17, 2025
…ative [DeviceASAN] Fix urKernelCreateWithNativeHandle segfault
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
[DeviceASAN] Fix urKernelCreateWithNativeHandle segfault
iclsrc
pushed a commit
that referenced
this pull request
Apr 21, 2025
…nstruction (#3108) This is a follow-up fix to #2506 Original commit: KhronosGroup/SPIRV-LLVM-Translator@7c149b86978f8fc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are deprecating legacy env vars SYCL_BE and SYCL_DEVICE_TYPE.
This PR is intended to inform users about this change during the grace period.
Signed-off-by: Byoungro So [email protected]