Skip to content

[SYCL][NFC] Removing "default label in switch" revealed by self build. #3108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

zahiraam
Copy link
Contributor

@zahiraam zahiraam commented Jan 27, 2021

No description provided.

enumeration values" error revealed in self build.
@zahiraam zahiraam changed the title [SYCL][NFC] Removing "default label in switch which covers all [SYCL][NFC] Removing "default label in switch" revealed by self build. Jan 27, 2021
Copy link
Contributor

@smaslov-intel smaslov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default cases are very useful for plugin, so we added -Wno-covered-switch-default to sycl/plugins/CMakeLists.txt.

Do you still see the problem? Which?

@zahiraam
Copy link
Contributor Author

Default cases are very useful for plugin, so we added -Wno-covered-switch-default to sycl/plugins/CMakeLists.txt.

Do you still see the problem? Which?
Oh! I hadn't merged in the CMakeList.txt. With this a few of them are gone. There is one (so far) that I still see:
sycl/source/detail/device_info.hpp
But adding the flag in sycl/source/CMakeList.txt seems to fix the issue.
In this case for the upcoming one(s) I will instead add the flag in the corresponding CMakeList.

@smaslov-intel
Copy link
Contributor

But adding the flag in sycl/source/CMakeList.txt seems to fix the issue.

I think we didn't agree that we want that flag generally for all of SYCL, so chose to use that for plugins only.
The "default" in sycl/source/detail/device_info.hpp is to be removed.

@zahiraam
Copy link
Contributor Author

But adding the flag in sycl/source/CMakeList.txt seems to fix the issue.

I think we didn't agree that we want that flag generally for all of SYCL, so chose to use that for plugins only.
The "default" in sycl/source/detail/device_info.hpp is to be removed.

Understood. I will therefore abandon this change. But more will be coming with the default case removed.

@v-klochkov
Copy link
Contributor

v-klochkov commented Feb 10, 2021

But adding the flag in sycl/source/CMakeList.txt seems to fix the issue.

I think we didn't agree that we want that flag generally for all of SYCL, so chose to use that for plugins only.
The "default" in sycl/source/detail/device_info.hpp is to be removed.

Understood. I will therefore abandon this change. But more will be coming with the default case removed.

@zahiraam - is this PR abandoned? If yes, please close it.

@zahiraam zahiraam closed this Feb 10, 2021
iclsrc pushed a commit that referenced this pull request Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants