[SYCL] Fix rectangle argument order when passing to PI routines #2608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
s-kanaev
reviewed
Oct 8, 2020
|
/summary:run |
Signed-off-by: Chris Perkins <[email protected]>
romanovvlad
reviewed
Oct 12, 2020
smaslov-intel
previously approved these changes
Oct 12, 2020
s-kanaev
reviewed
Oct 13, 2020
Signed-off-by: Chris Perkins <[email protected]>
romanovvlad
reviewed
Oct 14, 2020
Signed-off-by: Chris Perkins <[email protected]>
romanovvlad
approved these changes
Oct 16, 2020
|
pinging reviewers. |
s-kanaev
approved these changes
Oct 19, 2020
smaslov-intel
approved these changes
Oct 19, 2020
iclsrc
pushed a commit
that referenced
this pull request
Jul 5, 2024
They can be used as SPIR-V friendly calls as there is no obvious mapping to any existing LLVM instruction. The tests are basically copying the ones added in #2392 This change will address the second part of #2302 issue Original commit: KhronosGroup/SPIRV-LLVM-Translator@c75fab28b73642e
iclsrc
pushed a commit
that referenced
this pull request
Jul 26, 2024
They can be used as SPIR-V friendly calls as there is no obvious mapping to any existing LLVM instruction. The tests are basically copying the ones added in #2392 This change will address the second part of #2302 issue Original commit: KhronosGroup/SPIRV-LLVM-Translator@c75fab28b73642e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For 2D and 3D buffers and images, some of the arguments passed to the plugin interface are not always correct or in the right order. For example, with 2D buffer we pass height-in-bytes, rather than width-in-bytes as part of a region or offset argument. This fixes this, slightly expands the PI Trace, and and also adds testing so we can more easily observe and catch this. Note that presently, images and buffers use multidimensional range/ids in the reverse order of each other. This fix does not attempt to unify those representations, but comments have been added to help clarify this in the future.