[SYCL][ESIMD] Add histogram 256 bin test using SLM #2392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbatashev
previously approved these changes
Sep 1, 2020
There was a problem hiding this comment.
Other comments from #2387 can be considered resolved. LGTM.
alexbatashev
reviewed
Sep 1, 2020
cmc-rep
force-pushed
the
cmc-rep-change1
branch
from
59a443d to
b9381c5
Compare
alexbatashev
previously approved these changes
Sep 2, 2020
bader
changed the title
bader
previously requested changes
Sep 2, 2020
Signed-off-by: Gang Y Chen <[email protected]>
cmc-rep
force-pushed
the
cmc-rep-change1
branch
from
b9381c5 to
c9e82e3
Compare
bader
dismissed
their stale review
Build issues should be fixed by latest rebase.
alexbatashev
approved these changes
Sep 4, 2020
jsji
pushed a commit
that referenced
this pull request
Mar 14, 2024
The fix adds support for IR builtin calls __spirv_IAddCarry and __spirv_ISubBorrow. It's also first part of fix which removes noncompliance of uadd/sub_with_overflow intrinsics. SPIRVUtil changes are needed to support situations where builtin don't have corresponding store instruction. Original commit: KhronosGroup/SPIRV-LLVM-Translator@63fd35158554695
iclsrc
pushed a commit
that referenced
this pull request
Jul 5, 2024
They can be used as SPIR-V friendly calls as there is no obvious mapping to any existing LLVM instruction. The tests are basically copying the ones added in #2392 This change will address the second part of #2302 issue Original commit: KhronosGroup/SPIRV-LLVM-Translator@c75fab28b73642e
iclsrc
pushed a commit
that referenced
this pull request
Jul 26, 2024
They can be used as SPIR-V friendly calls as there is no obvious mapping to any existing LLVM instruction. The tests are basically copying the ones added in #2392 This change will address the second part of #2302 issue Original commit: KhronosGroup/SPIRV-LLVM-Translator@c75fab28b73642e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gang Y Chen [email protected]
Sorry, I have to recreate this pull request with a new branch. I am new to this. my old branch was in bad state
I have addressed all the comments in the old PR.