[SYCL][Doc] Minor fixes to local_memory extension text #2621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Kinsner <[email protected]>
Pennycook
reviewed
Oct 9, 2020
| for the object is allocated upon or before the first call to | ||
| `group_local_memory`, and deallocated when all work-items in the group have | ||
| completed execution of the kernel. | ||
|
|
||
| All arguments in _args_ must be the same for all work-items in the group. |
There was a problem hiding this comment.
Did you mean to remove this line?
bader
added
the
spec extension
mlychkov
reviewed
Feb 19, 2021
| @@ -191,13 +191,11 @@ extension.] | |||
| multi_ptr<T, Group::address_space> group_local_memory_for_overwrite(Group g)` | | |||
| Constructs an object of type `T` in an address space accessible by all | |||
| work-items in group _g_, using default initialization. The object is | |||
| initialized pon or before the first call to `group_local_memory`. The storage | |||
| default initialized on or before the first call to `group_local_memory`. The storage | |||
| for the object is allocated upon or before the first call to | |||
| `group_local_memory`, and deallocated when all work-items in the group have | |||
There was a problem hiding this comment.
Suggested change
| `group_local_memory`, and deallocated when all work-items in the group have | |
| `group_local_memory_for_overwrite`, and deallocated when all work-items in the group have |
| @@ -191,13 +191,11 @@ extension.] | |||
| multi_ptr<T, Group::address_space> group_local_memory_for_overwrite(Group g)` | | |||
| Constructs an object of type `T` in an address space accessible by all | |||
| work-items in group _g_, using default initialization. The object is | |||
| initialized pon or before the first call to `group_local_memory`. The storage | |||
| default initialized on or before the first call to `group_local_memory`. The storage | |||
There was a problem hiding this comment.
Suggested change
| default initialized on or before the first call to `group_local_memory`. The storage | |
| default initialized on or before the first call to `group_local_memory_for_overwrite`. The storage |
kbenzie
pushed a commit
to kbenzie/intel-llvm
that referenced
this pull request
Feb 17, 2025
[benchmarks] use manifest to build compute-runtime dependencies
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
[benchmarks] use manifest to build compute-runtime dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Kinsner [email protected]