Skip to content

[SYCL][Doc] Minor fixes to local_memory extension text #2621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SYCL][Doc] Minor fixes to local_memory extension text #2621

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions sycl/doc/extensions/LocalMemory/SYCL_INTEL_local_memory.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,16 +56,16 @@ products.
== Version

Built On: {docdate} +
Revision: 1
Revision: 2

== Contact

John Pennycook, Intel (john 'dot' pennycook 'at' intel 'dot' com)
John Pennycook, Intel (john 'dot' pennycook 'at' intel 'dot' com) +
Roland Schulz, Intel (roland 'dot' schulz 'at' intel 'dot' com)

== Contributors

Felipe de Azevedo Piovezan, Intel
Felipe de Azevedo Piovezan, Intel +
Michael Kinsner, Intel

== Dependencies
Expand Down Expand Up @@ -191,13 +191,11 @@ extension.]
multi_ptr<T, Group::address_space> group_local_memory_for_overwrite(Group g)` |
Constructs an object of type `T` in an address space accessible by all
work-items in group _g_, using default initialization. The object is
initialized pon or before the first call to `group_local_memory`. The storage
default initialized on or before the first call to `group_local_memory`. The storage
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
default initialized on or before the first call to `group_local_memory`. The storage
default initialized on or before the first call to `group_local_memory_for_overwrite`. The storage

for the object is allocated upon or before the first call to
`group_local_memory`, and deallocated when all work-items in the group have
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`group_local_memory`, and deallocated when all work-items in the group have
`group_local_memory_for_overwrite`, and deallocated when all work-items in the group have

completed execution of the kernel.

All arguments in _args_ must be the same for all work-items in the group.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to remove this line?


`Group` must be `sycl::group`, and `T` must be trivially destructible.
[_Note_ - These restrictions may be lifted in a future version of this
extension.]
Expand All @@ -216,6 +214,7 @@ None.
|========================================
|Rev|Date|Author|Changes
|1|2020-08-18|John Pennycook|*Initial public working draft*
|2|2020-10-09|Mike Kinsner|Fix minor text errors
|========================================

//************************************************************************
Expand Down