[SYCL] properly report supported device partitioning in Level-Zero #2751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergey V Maslov <[email protected]>
romanovvlad
reviewed
Nov 10, 2020
againull
requested changes
Nov 12, 2020
Signed-off-by: Sergey V Maslov <[email protected]>
againull
reviewed
Nov 12, 2020
Signed-off-by: Sergey V Maslov <[email protected]>
againull
approved these changes
Nov 12, 2020
|
run_on_host_intel2 is a known issue which is being fixed in #2766 |
|
@smaslov-intel Can we wait until #2766 is merged or we need this ASAP? |
It can wait. |
|
I think #2766 can be merged right away to unblock pre-commit testing of other PRs. |
|
#2766 merged, can you please rebase this PR. |
Or just re-run sycl-win-x64-pr job. |
jsji
pushed a commit
that referenced
this pull request
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make adhere to SYCL spec:
[info::device::partition_properties]: returns the partition properties
supported by this SYCL device; a vector of info::partition_property. If this
SYCL device cannot be partitioned into at least two sub devices then the
returned vector must be empty.
[create_sub_devices()]: If the SYCL device
does not support info::partition_property::partition_by_affinity_domain or the
SYCL device does not support the info::partition_affinity_domain provided, an
exception with the feature_not_supported error code must be thrown.
Signed-off-by: Sergey V Maslov [email protected]