[SYCL][NFC] Improve type traits' usage in headers & runtime #2768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AGindinson
requested review from
againull,
smaslov-intel,
turinevgeny and
a team
as code owners
AGindinson
force-pushed
the
private/agindins/templates-refactor
branch
2 times, most recently
from
1f535fa to
3bcf70c
Compare
The patch aims to: 1. Facilitate consistent usage of type traits accross the SYCL library. 2. Make a potential switch to C++14 STL type traits easier to perform. The following traits were affected: - `enable_if` - `remove_const` - `remove_reference` - `conditional` - `remove_pointer` - `remove_cv` An overview of the changes: 1. Wherever possible, `std::[trait]<>::type` usages were replaced with `detail::[trait]_t<>`. 2. The corresponding `std::[trait]_t<>` usages were also replaced, as we're still supposed to comply with C++11. 3. The type traits-related `#include` directives were slightly re-organized with some removal of obsolete ones. 4. Some duplicating code was removed from `detail/stl_type_traits.hpp`. Signed-off-by: Artem Gindinson <[email protected]>
AGindinson
force-pushed
the
private/agindins/templates-refactor
branch
from
49dda7b to
8b7f89c
Compare
Signed-off-by: Artem Gindinson <[email protected]>
againull
approved these changes
Nov 16, 2020
jsji
pushed a commit
that referenced
this pull request
Nov 22, 2024
fixes #2768 Generate an LLVM memcpy for OpCopyLogical, rather than a call to an OpCopyLogical function. Original commit: KhronosGroup/SPIRV-LLVM-Translator@1a1bf17d9e8684c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch aims to:
The following traits were affected:
enable_ifremove_constremove_referenceconditionalremove_pointerremove_cvAn overview of the changes:
std::[trait]<>::typeusages were replaced withdetail::[trait]_t<>.std::[trait]_t<>usages were also replaced, as we're still supposed to comply with C++11.#includedirectives were slightly re-organized with some removal of obsolete ones.detail/stl_type_traits.hpp.Signed-off-by: Artem Gindinson [email protected]