Skip to content

[SYCL] Fix build error on Windows by checkin _WIN32 macro instead of … #2825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

v-klochkov
Copy link
Contributor

…WIN32

Signed-off-by: Vyacheslav Klochkov [email protected]

@v-klochkov v-klochkov requested a review from a team as a code owner November 27, 2020 05:15
@v-klochkov
Copy link
Contributor Author

The code checkin WIN32 macro somehow worked in CI and also on my work laptop, but the compiler build failed on my home computer.
I replaced "WIN32" macro check with "_WIN32" in global_scheduler.cpp to unify the windows checks with other places in SYCL.
Also, Microsoft docs tell only about _WIN32 here: https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-160

@bader bader merged commit c6b9973 into intel:sycl Nov 27, 2020
@v-klochkov v-klochkov deleted the public_vklochkov_win32_macro_build_error branch November 28, 2020 22:54
jsji pushed a commit that referenced this pull request Nov 22, 2024
fixes #2768

Generate an LLVM memcpy for OpCopyLogical, rather than a call to an OpCopyLogical function.

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@1a1bf17d9e8684c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants