[SYCL] Add online compilation API interface (Intel extension). #2901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-klochkov
reviewed
Dec 17, 2020
v-klochkov
reviewed
Dec 17, 2020
|
Vào Th 5, 17 thg 12, 2020 lúc 13:47 Vyacheslav Klochkov <
[email protected]> đã viết:
… ***@***.**** commented on this pull request.
------------------------------
In sycl/include/CL/sycl/INTEL/online_compiler.hpp
<#2901 (comment)>:
> @@ -0,0 +1,192 @@
+//===------- online_compiler.hpp - Online source compilation service ------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
⬇️ Suggested change
-
+
+#pragma once
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2901 (review)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQBNS73IKRD53DPHV4FDY73SVGSQLANCNFSM4U66B44A>
.
|
v-klochkov
previously approved these changes
Dec 17, 2020
jbrodman
previously approved these changes
Dec 18, 2020
This API is aimed at compiling various source languages (e.g. OpenCL) to binary format. Only SPIRV is supported for now. Signed-off-by: Konstantin S Bobrovsky <[email protected]>
Signed-off-by: Konstantin S Bobrovsky <[email protected]>
Signed-off-by: Konstantin S Bobrovsky <[email protected]>
kbobrovs
force-pushed
the
online-compile
branch
from
5ac86db to
e10bf19
Compare
|
@jbrodman, please re-approve. I changed enum values to lower case per @Pennycook's request in #2913. Had to force-push due to rebase. |
Pennycook
approved these changes
Dec 19, 2020
v-klochkov
approved these changes
Dec 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This API is aimed at compiling various source languages (e.g. OpenCL) to
binary format. Only SPIRV is supported for now. This was internally discussed and
approved at Intel.
Formal doc: #2913
Signed-off-by: Konstantin S Bobrovsky [email protected]