Skip to content

[SYCL] Add online compilation extension spec. #2913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 21, 2020
Merged

[SYCL] Add online compilation extension spec. #2913

merged 5 commits into from
Dec 21, 2020

Conversation

kbobrovs
Copy link
Contributor

Formal document for #2901

Signed-off-by: Konstantin S Bobrovsky [email protected]

@kbobrovs kbobrovs requested a review from a team as a code owner December 18, 2020 22:51
Pennycook
Pennycook requested changes Dec 18, 2020
View reviewed changes
kbobrovs and others added 2 commits December 18, 2020 15:53
@kbobrovs kbobrovs requested a review from Pennycook December 18, 2020 23:59
@kbobrovs
Make output format enum values lower-case.
621fc7c 
Signed-off-by: Konstantin S Bobrovsky <[email protected]>
@kbobrovs
spirv -> spir_v
3d5f616 
Signed-off-by: Konstantin S Bobrovsky <[email protected]>
@kbobrovs kbobrovs mentioned this pull request Dec 19, 2020
Merged
@vladimirlaz
Copy link
Contributor

Could you please clarify if compilation in this document means compilation only or compilation+linkage?

  1. if first how the linkage can be done? Can we link multiple modules?
  2. if second can it be state explicitly in the doc?

@v-klochkov v-klochkov mentioned this pull request Dec 21, 2020
Merged
@kbobrovs
Copy link
Contributor Author

Could you please clarify if compilation in this document means compilation only or compilation+linkage?

  1. if first how the linkage can be done? Can we link multiple modules?
  2. if second can it be state explicitly in the doc?

It means compilation only. Doing linkage is outside of the scope of this specification. SYCL 1.2.1/2020 provides ways to further link or otherwise handle the resulting code.

@v-klochkov v-klochkov merged commit e05a19c into intel:sycl Dec 21, 2020
@kbobrovs kbobrovs deleted the online-compile-spec branch January 19, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pennycook Pennycook Pennycook approved these changes

@v-klochkov v-klochkov v-klochkov approved these changes

@jbrodman jbrodman Awaiting requested review from jbrodman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kbobrovs @vladimirlaz @Pennycook @v-klochkov