[clang-offload-bundler] Initialize member names in unbundled archive #3049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member names in the unbundled archive were not properly initialized which could lead to random problems for tools working with these archives later. This patch fixes this problem. There is no LIT test in this patch because it is impossible to create stable test which shows the problem. Signed-off-by: Sergey Dmitriev <[email protected]>
kbobrovs
previously approved these changes
Jan 19, 2021
Co-authored-by: kbobrovs <[email protected]>
bader
approved these changes
Jan 19, 2021
kbobrovs
approved these changes
Jan 19, 2021
iclsrc
pushed a commit
that referenced
this pull request
Mar 28, 2025
…3050) Instead of checking that the image operands are equal to the LOD mask, check that the LOD bit is in the image operands. This way an LOD value of zero may be ignored even when image operands contains bits other than the LOD bit, such as for the SPIR-V 1.6 nontemporal image operand. fixes #3049 Original commit: KhronosGroup/SPIRV-LLVM-Translator@4b18b19832697fa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Member names in the unbundled archive were not properly initialized
which could lead to random problems for tools working with these
archives later. This patch fixes this problem.
There is no LIT test in this patch because it is impossible to create
stable test which shows the problem.
Signed-off-by: Sergey Dmitriev [email protected]