[SYCL][NFC] Fix warnings reported by Clang #3050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 18, 2021 13:31
This reverts commit c99199c.
* sycl: [sycl-post-link][NFC] Extracted the code into a subroutine (intel#3042) [SYCL][NFC] Remove commented out code (intel#3029) [CODEOWNERS] Fix ownership of DPC++ tools tests (intel#3047) [SYCL][NFC] Make tests insensitive to dso_local (intel#3037) [SYCL] Fix acquiring a mutex in _pi_context::finalize (intel#3001) [SYCL] Fix various compilation warnings in plugins (intel#2979)
smaslov-intel
approved these changes
Jan 18, 2021
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Jan 19, 2021
* sycl: [SYCL][NFC] Fix warnings reported by Clang (intel#3050) [SYCL] Enhance device libraries filename check when constructing llvm-link commands (intel#2944) [SYCL][NFC] Add vtable ABI checks (intel#3032) [SYCL] Cleanup the deprecated Intel attribute logic (intel#3036)
iclsrc
pushed a commit
that referenced
this pull request
Mar 28, 2025
…3050) Instead of checking that the image operands are equal to the LOD mask, check that the LOD bit is in the image operands. This way an LOD value of zero may be ignored even when image operands contains bits other than the LOD bit, such as for the SPIR-V 1.6 nontemporal image operand. fixes #3049 Original commit: KhronosGroup/SPIRV-LLVM-Translator@4b18b19832697fa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.