Skip to content

[SYCL] [L0] Remove signaled events from wait list by default #3155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 5, 2021
Merged

[SYCL] [L0] Remove signaled events from wait list by default #3155

merged 3 commits into from
Feb 5, 2021

Conversation

asudarsa
Copy link
Contributor

@asudarsa asudarsa commented Feb 4, 2021

Signed-off-by: Arvind Sudarsanam [email protected]

@asudarsa asudarsa changed the title [SYCL] [L0] Turn on remove finished events from wait list [SYCL] [L0] Remove signaled events from wait list by default Feb 4, 2021
@smaslov-intel
Copy link
Contributor

Let's run as much as possible pre-commit testing for this change.

@smaslov-intel
Copy link
Contributor

/summary:run

@asudarsa asudarsa requested a review from a team as a code owner February 4, 2021 01:09
Copy link
Contributor

@smaslov-intel smaslov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please make sure no regression from the summary pre-commit testing before merging.

@asudarsa
Copy link
Contributor Author

asudarsa commented Feb 5, 2021

/summary:run

@bader
Copy link
Contributor

bader commented Feb 5, 2021

LGTM, please make sure no regression from the summary pre-commit testing before merging.

The tests pass for original commit and follow-up commits modified documentation only, so I think it's okay.

@bader bader merged commit c9d71d4 into intel:sycl Feb 5, 2021
jsji pushed a commit that referenced this pull request May 30, 2025
Update after llvm commits
50e949f ("[IR] Teach getAsmString to return StringRef (NFC)
(#139406)", 2025-05-10) and
58014a5 ("[IR] Teach getConstraintString to return StringRef (NFC)
(#139401)", 2025-05-10).

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@c45ad2498b1eef8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants